Fix Docker file#66
Merged
Merged
Conversation
* Removed `applicationinsights.json` from `.gitignore` as that prevents docker from finding that file, as docker reads and respects `.gitignore`. * Fixed file permissions: - Only script files should be executable. - No file should be writable. - Files should be readable. * Fixed `HEALTHCHECK`. The Ubuntu base image used by our `eclipse-temurin` Docker base image, does not provide `curl` or any other alterntives. Instead of installing `curl` and polluting the image with APT cache stuff, a simple custom Java based applet is used to check the status. This allows us to in the future to also switch to completely distroless base images.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applicationinsights.jsonfrom.gitignoreas that prevents docker from finding that file, as docker reads and respects.gitignore.HEALTHCHECK. The Ubuntu base image used by oureclipse-temurinDocker base image, does not providecurlor any other alterntives. Instead of installingcurland polluting the image with APT cache stuff, a simple custom Java based applet is used to check the status. This allows us to in the future to also switch to completely distroless base images.This change is